Fix availableBlocks override eachother #2503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
fix-availability-override
branch
from
cc173bd
to
2deb0de
Compare
Tofandel
commented
Feb 27, 2024
| @@ -265,7 +267,7 @@ | |||
| } | |||
| }, | |||
| checkIfBlockTypeIsAvailable (editorName, type) { | |||
| const availableBlocks = JSON.parse(JSON.stringify(this.availableBlocks(editorName))) | |||
| const availableBlocks = this.availableBlocks(editorName) | |||
There was a problem hiding this comment.
No need to deepclone this in this function, it's only being searched
| @@ -179,9 +182,8 @@ | |||
| }), | |||
| ...mapGetters([ | |||
| 'blocks', | |||
| 'fieldsByBlockId', | |||
There was a problem hiding this comment.
This is not used in the component
Tofandel
force-pushed
the
fix-availability-override
branch
2 times, most recently
from
41a8103
to
d36a511
Compare
Tofandel
force-pushed
the
fix-availability-override
branch
from
d36a511
to
cc8b474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2502
Simple fix is to add a unique id when rendering the component to find the correct availability key
Also included a bit of future proofing and backward compatibility even if the partial is overidden