Implement endpoint params in Browser form field #2752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zachgarwood, I'm probably missing something as your issue describes the problem well so I'm sure you've experienced it, but the params are already supposed to be added to the endpoint(s( URL server side in the Browser field component class: andIt was working the same way in Twill 2. The logic has just been moved from the blade file to the component class. |
|
Ok, I understand the problem now. Because you are passing "raw" endpoints, the lines I linked above do not apply. I think the params could still be appended server side instead of through the vuex state in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change completes the partially implemented
paramsoption for the Browser form field.Related Issues
Fixes #2751