Skip to content

Properly set search string in Global Search #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

nikhiltri
Copy link
Contributor

Description

The cmsSearch() method in ModuleController uses the FreeTextSearch model and sets:

        $searchFilter->queryString($search);
        $searchFilter->searchColumns($fields);
        $searchFilter->searchQuery($query);

The FreeTextSearch model, however, has a condition that requires searchString to not be empty, and that value is never set in cmsSearch(). It gets set by the searchFor() method which never gets called.

Adding:

        $searchFilter->searchFor($search);

Makes global search work as expected for me.

Related Issues

Fixes #2762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Search not properly getting search string
1 participant