WIP: Try to automatically reconnect when connection is lost #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilioPeJu
force-pushed
the
auto-reconnect
branch
2 times, most recently
from
e7cf108
to
b8cf461
Compare
ericonr
reviewed
Feb 1, 2024
EmilioPeJu
changed the title
There is a parameter to disable this behaviour if needed
EmilioPeJu
force-pushed
the
auto-reconnect
branch
from
b8cf461
to
64404e6
Compare
|
Thanks for reviewing, this PR needs to be changed to do a different approach using the standard asyn auto-connect mechanism, I've marked it as WIP until it's implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a parameter to disable this behaviour if needed.
For sake of simplicity, the camera parameter resynchronization is left to the user, in my specific application, I rely on the UserSetSave feature.