Support variable character limit in NDAttributesFile#550
Merged
MarkRivers merged 1 commit intoareaDetector:masterfrom Aug 26, 2025
Merged
Conversation
callumforrester
changed the title
Member
|
I think the macro should be used for the NELM field rather than FTVL? |
callumforrester
force-pushed
the
configurable-ndattributes-char-limit
branch
from
41f65ec to
3f0d0cb
Compare
Contributor
Author
|
Thanks @jwlodek, I should actually read before I push! |
Member
|
Note that the XML layout file for the HDF5 plugin can also be directly contained in the XMLFileName record. The ability to specify the size of that waveform record was added in lines 676 and 685 in this commit: 5ad2a68 For consistency I suggest using the same XMLSIZE macro that is used in that file. |
Following areaDetector#503 the NDAttributesFile record can also directly contain an XML string, however the record is still limited to 256 characters, which may not be enough to accomodate a large blob of XML. This adds a macro, XMLSIZE, with a default of 256, so IOCs can be configured to accomodate larger blobs of XML.
callumforrester
force-pushed
the
configurable-ndattributes-char-limit
branch
from
3f0d0cb to
91fbd75
Compare
Contributor
Author
|
@MarkRivers thanks, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #503 the NDAttributesFile record can also directly contain an XML string, however the record is still limited to 256 characters, which may not be enough to accomodate a large blob of XML. This adds a macro,
XMLSIZE, with a default of 256, so IOCs can be configured to accomodate larger blobs of XML.