Map TemperatureAbs feature to ADTemperatureActual PV #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basler cameras implement temperature feature as TemperatureAbs [1] instead of DeviceTemperature. Make this a multi-feature which supports either names to correctly map to the standard ADDriver PV. [1] https://docs.baslerweb.com/temperature-state
henriquesimoes
added a commit
to lnls-sirius/dev-packages
that referenced
this pull request
Oct 1, 2024
ADDriver `Temperature` PV maps to a set-point PV for changing temperature when this is supported by the device. The actual temperature should be reported by TemperatureActual PV, but it is not correctly mapped for Basler cameras yet [1]. Map directly to the GenICam feature called TemperatureAbs for the new IOC instead, while falling back to the accelerator high-level PV for BO_DVF. [1] github.com/areaDetector/ADGenICam/pull/44
henriquesimoes
added a commit
to lnls-sirius/dev-packages
that referenced
this pull request
Oct 2, 2024
ADDriver `Temperature` PV maps to a set-point PV for changing temperature when this is supported by the device. The actual temperature should be reported by TemperatureActual PV, but it is not correctly mapped for Basler cameras yet [1]. Map directly to the GenICam feature called TemperatureAbs for the new IOC instead, while falling back to the accelerator high-level PV for BO_DVF. [1] areaDetector/ADGenICam#44
henriquesimoes
added a commit
to lnls-sirius/dev-packages
that referenced
this pull request
Oct 7, 2024
ADDriver `Temperature` PV maps to a set-point PV for changing temperature when this is supported by the device. The actual temperature should be reported by TemperatureActual PV, but it is not correctly mapped for Basler cameras yet [1]. Map directly to the GenICam feature called TemperatureAbs for the new IOC instead, while falling back to the accelerator high-level PV for BO_DVF. [1] areaDetector/ADGenICam#44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basler cameras implement temperature feature as TemperatureAbs instead of DeviceTemperature. Make this a multi-feature which supports either names to correctly map to the standard ADDriver PV.
I haven't been able to test this yet. I hope I can do this in the following days.