sfc: fix PowerFest '94 and Campus Challenge '92 #1654
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaced by #1656 |
LukeUsher
pushed a commit
that referenced
this pull request
Oct 1, 2024
Needs to merge #1654 first. Enables loading folders instead files from cmd line. Removes loading firmware files from rom folders in sfc mia (firmware data would be loaded twice, db hashes would not match anymore).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on database fixes and research from #1648 (thx @DerekTurtleRoe, remutro & SuperMikeMan100!)
Fixes #1361
Only supports the merged one-file ROMs for these games (without appended firmware).
Also sets the default dip value for the known competition boards to 0x03 for 6 minutes (default mode used in these competitions)
See for dip settings:
https://www.snesmaps.com/maps/NintendoPowerFest94/NintendoPowerFest94.html
https://www.snesmaps.com/maps/1992Challenge/1992Challenge.html
Nitpick: The mia database for existing sfc games only contains sha256 hashes including all appended firmware - these two competition games use the hash WITHOUT firmware (=matches the no-intro hashes).