n64: remove call to epilogue function from the jit#1663
Merged
LukeUsher merged 1 commit intoares-emulator:masterfrom Oct 28, 2024
Merged
n64: remove call to epilogue function from the jit#1663LukeUsher merged 1 commit intoares-emulator:masterfrom
LukeUsher merged 1 commit intoares-emulator:masterfrom
Conversation
Contributor
|
Sorry for the delay. I will try to review this in the next few days. |
invertego
approved these changes
Oct 18, 2024
| if(!self.icache.coherent(vaddr, address)) | ||
| return nullptr; | ||
|
|
||
| bool abort = false; |
| if constexpr(Recompiled) { | ||
| //simulates timings without performing actual icache loads | ||
| icache.step(ipu.pc, devirtualizeFast(ipu.pc)); | ||
| assert(ipu.r[0].u64 == 0); |
Contributor
There was a problem hiding this comment.
A little concerned about losing this assert in debug builds. I guess we could replace it with a check in the JITed code. Not saying this has to be addressed in this PR, but I wanted to make note of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.