[N64] allow for pak swapping on controller port 1 #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows for all pak swapping on controller port 1 only. It also enables support for the transfer pak for the 64DD which was previously missing.
It is being added for port 1 only now because there is additional work to manage all the different saves, and gameboy games/saves with the transfer pak which is a larger effort, and Luke is currently looking into modifying settings in a more complete manner. So other ports can be added later. For most people, being able to swap for the first controller is likely good enough.
This pull request doesn't change any of the current initialization logic regarding default pak selection that already existed.