n64: add unusual warning when using CACHE on uncached addresses #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CACHE opcode does not work correctly when the specified virtual address is in an uncached segment. The exact hardware behavior has not been reversed yet (we know for instance that when doing cache invalidation, some other cacheline is invalidated instead, but we do not know the relation yet). Nonetheless, the behavior is really obscure and all usages should be considered bugs. Add a debug unusual warning for now (mainly to help developers, as this is a known instance where Ares doesn't yet follow hardware behavior).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CACHE opcode does not work correctly when the specified virtual address is in an uncached segment. The exact hardware behavior has not been reversed yet (we know for instance that when doing cache invalidation, some other cacheline is invalidated instead, but we do not know the relation yet).
Nonetheless, the behavior is really obscure and all usages should be considered bugs. Add a debug unusual warning for now (mainly to help developers, as this is a known instance where Ares doesn't yet follow hardware behavior).