ares: move generated sources out of ares.hpp #1704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random fix from CMake work.
Precompiled headers under CMake are currently buggy and unreliable on Windows, largely because the precompiled
<ares/ares.hpp>header includes<ares/resource/resource.hpp>, which is generated bysourceryas part of the build process.While sourcery will almost never meaningfully change the contents of this
resource.hppfile, Windows may insert its own line endings depending on the user's environment, and despite enforcing uniform line endings as part of our.gitattributesfile, some compilers will throw a fit about the precompiled header being modified from underneath it.Since the
resource.hppfile is simple, short, and not included in that many places, we can just refactor it out of<ares/ares.hpp>without issue, and precompiled headers will work again regardless of system line ending convention or environment.Tested to build locally on macOS; CI run definitely recommended.