Skip to content

Comments

By default let HF download handle cache path for WhisperKitPro Engine#90

Merged
EduardoPach merged 2 commits intomainfrom
eduardo/wkp-download-path
Jan 5, 2026
Merged

By default let HF download handle cache path for WhisperKitPro Engine#90
EduardoPach merged 2 commits intomainfrom
eduardo/wkp-download-path

Conversation

@EduardoPach
Copy link
Collaborator

What does this PR do?

Problem

Pipeline aliases generate a new download path on each CLI run, bypassing the cache and causing unnecessary model re-downloads.

Solution

Delegate model caching to HuggingFace's built-in cache mechanism:

  • Downloading: When using repo_id + model_variant, models are stored in HF's default cache path, ensuring cache hits across runs
  • Local models: When model_dir is provided, models are loaded directly from that path (no download)

Changes

  • Extended model downloads to WhisperKitProOrchestrationPipeline
  • Added repo_id and model_variant for HF-managed downloads
  • Switched models_cache_dir logic to a simple model_dir to load models from a local path directly
  • Updated build_pipeline in transcription and orchestration to pass new fields to WhisperKitProConfig

@EduardoPach EduardoPach requested a review from dbrkn December 30, 2025 23:41
Copy link
Contributor

@dbrkn dbrkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EduardoPach EduardoPach merged commit 57990cd into main Jan 5, 2026
2 checks passed
@EduardoPach EduardoPach deleted the eduardo/wkp-download-path branch January 5, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants