Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use previous directory structure with operator-sdk 1.35 #1462

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this?
/kind chore

What does this PR do / why we need it:
This PR revert back the change done, i.e. /controllers directory was moved to /internal/controller that caused other project from accessing argocd as dependency.
With this PR we are reverting /internal/controller back to /controllers.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@anandrkskd anandrkskd marked this pull request as ready for review July 16, 2024 12:35
svghadi

This comment was marked as duplicate.

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link
Collaborator

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandrkskd!! LGTM!!

Copy link
Collaborator

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svghadi svghadi merged commit 806551f into argoproj-labs:master Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants