Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ArgoCD Redis HA components not updating during operator upgrades #1652

Merged
merged 12 commits into from
Feb 4, 2025

Conversation

Mangaal
Copy link
Contributor

@Mangaal Mangaal commented Jan 30, 2025

What type of PR is this?
This PR fixes an issue where updates to the Deployment argocd-redis-ha-haproxy and the StatefulSet argocd-redis-ha-server were not being reflected during OpenShift GitOps operator upgrades.

/kind bug

Steps to reproduce the issue:

Install OpenShift GitOps Operator v1.12.0 on an OCP 4.16.4 cluster.
Create an ArgoCD instance with .spec.ha.enabled = true.
Upgrade the operator to v1.14.0, v1.14.1, and v1.14.2.
Observe that the Deployment argocd-redis-ha-haproxy is not updated as expected.

@Mangaal Mangaal marked this pull request as ready for review January 30, 2025 06:56
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add some testing?

Signed-off-by: Mangaal <[email protected]>
@Mangaal Mangaal changed the title Fix ha redis sync Fix issue with ArgoCD Redis HA components not updating during operator upgrades Feb 3, 2025
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@svghadi svghadi merged commit 8210187 into argoproj-labs:master Feb 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants