Upgrade argocd to 2.14.13 and debug upgrade issues #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandf
changed the title
svghadi
reviewed
Mar 7, 2025
| @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.14.0 | |||
| controller-gen.kubebuilder.io/version: v0.17.2 | |||
There was a problem hiding this comment.
Is controller-gen upgrade required? If so, we will also need to update it in makefile
Lines 169 to 171 in 58532ce
There was a problem hiding this comment.
Yes, IIRC, this change was required for the compilation to succeed. Let me cross check and revert if not required.
There was a problem hiding this comment.
Yes, this was required to make the builds succeed with kubernetes API 0.31.0. Updated the Makefile too.
config/rbac/role.yaml
Outdated
There was a problem hiding this comment.
Are these permission changes done by code-gen automatically?
There was a problem hiding this comment.
Yes, these were generated by code-gen automatically.
anandf
changed the title
Signed-off-by: Anand Francis Joseph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: