IsObjectFound function should not bury unexpected errors #1728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Currently, the
IsObjectFound
utility function is used to check whether a particular object exists on the cluster. It is used across the codebase, and with many different types of objects.Unfortunately,
IsObjectFound
is making an incorrect assumption: this function assumes that ANY error that occurs (besides is not found) should be treated the same as the object not existing.For example:
IsObjectFound
returns trueIsObjectFound
returns falseIsObjectFound
returns falseNotice that B and C, despite very different causes, return the same false of
false
.This PR updates the function signature of
IsObjectFound
to return (rather than burying) theerror
, and updates all locations in the code where it is called.