Update redis-ha-haproxy replicas similar to redis #1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rizwana777
force-pushed
the
issue-6806-haproxy
branch
2 times, most recently
from
26af0d6 to
6a41700
Compare
Signed-off-by: Rizwana777 <[email protected]>
Rizwana777
force-pushed
the
issue-6806-haproxy
branch
from
6a41700 to
a6d68a6
Compare
|
/lgtm @Rizwana777 |
svghadi
reviewed
Jun 1, 2025
There was a problem hiding this comment.
Have some questions, other than that looks good. Thanks.
- Do we need any updates in https://github.com/argoproj-labs/argocd-operator/blob/master/build/redis/haproxy.cfg.tpl to support multiple replicas?
- Can you run some tests to verify that traffic is routed correctly when one HAProxy replica goes down?
tested |
|
Thanks @Rizwana777 and thanks @svghadi and @jparsai for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://issues.redhat.com/browse/GITOPS-6806