feat (logs): enforce logs RBAC as first-class citizen in Argo CD 3.0 #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min roles Signed-off-by: Atif Ali <[email protected]>
aali309
changed the title
Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This change is part of the Argo CD 3.0 upgrade path, where logs RBAC enforcement
is now a first-class citizen. Users upgrading from 2.4 will need to:
What does this PR do / why we need it:
This change implements the logs RBAC enforcement changes required for Argo CD 3.0,
where logs permissions are now enforced by default and the legacy flag
server.rbac.log.enforce.enable is removed.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
See 21678
How to test changes / Special notes to the reviewer: