feat: add insecure and caRef to generator Gitlab
#760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
feat/add-caref-and-insecure
branch
from
e23eb23 to
a67d21a
Compare
chansuke
requested review from
blakepettersson,
mkilchhofer,
oboukili,
onematchfox and
the-technat
as code owners
Collaborator
|
Hi @chansuke thanks for your PR! This already looks quite good. One thing that's missing is the documentation. Woud you mind running a Also do you think it's feasable to create a test for this or extending an existing one to E2E check if the field arrives in Argo CD? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #669
How to test changes / Special notes to the reviewer: