Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): support display sync wave #20614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

linghaoSu
Copy link
Contributor

Fixes #20585

This PR adds the ability to set up the display of sync waves in the sync result list. Since this list already has too many columns, I’ve provided a checkbox to choose whether to display it or not.

After

20241031-202857.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu linghaoSu requested a review from a team as a code owner October 31, 2024 12:30
Copy link

bunnyshell bot commented Oct 31, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@andrii-korotkov-verkada
Copy link
Contributor

Maybe we can still just show by default to reduce developer friction.

@linghaoSu
Copy link
Contributor Author

Maybe we can still just show by default to reduce developer friction.

Hi @andrii-korotkov-verkada, thank you for your suggestion! Should I just remove the checkbox or set the default value of "display sync wave" to true?

I initially set it to false because some of my apps don’t specify a sync wave, so they would all have the same value, making this column unnecessary in that case. That’s why I chose to keep the default as false.

@andrii-korotkov-verkada
Copy link
Contributor

andrii-korotkov-verkada commented Nov 4, 2024

Hi @andrii-korotkov-verkada, thank you for your suggestion! Should I just remove the checkbox or set the default value of "display sync wave" to true?

Yeah, that's what I'm thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break down resources on the Sync page by the sync wave
2 participants