Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Requests info for Cpu and Mem added to Pod details #20637

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Nov 1, 2024

Resolves issue: #19457

1. Added the pod requests info to the Pod tooltip.

  • This will only show if the pod currently has some reserved requests (running pods with allocated requests).

  • When the pod completes successfully or fails with an error, the requests will be shown as 0 since they are no longer reserved.
    (also if the resources aren't declared )

2. For the original request of adding the top/parent resource groups,

  • there wasn't a good place to add a hover. Instead, I added an info div, similar to the one used for creation and revision, for the group. The tooltip on hover shows the combined requests for the group.

Added tests in info.go f and utils.test for scenerios of completed and failed state with allocated resources.

whole-pod-view-test.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Surajyadav <[email protected]>
@surajyadav1108 surajyadav1108 requested a review from a team as a code owner November 1, 2024 12:10
Copy link

bunnyshell bot commented Nov 1, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@d761c94). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20637   +/-   ##
=========================================
  Coverage          ?   55.16%           
=========================================
  Files             ?      324           
  Lines             ?    55203           
  Branches          ?        0           
=========================================
  Hits              ?    30451           
  Misses            ?    22143           
  Partials          ?     2609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant