Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added few more article link of argocd to readme #20646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added few more article link of argocd to readme #20646

wants to merge 1 commit into from

Conversation

sharadhirao
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@sharadhirao sharadhirao requested review from a team as code owners November 2, 2024 14:09
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 2, 2024 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

nitishfy
nitishfy reviewed Nov 4, 2024
View reviewed changes
README.md
1. [Argo CD - A GitOps Tool for continuous Delivery](https://medium.com/@raosharadhi11/argo-cd-a-gitops-tool-for-continuous-delivery-12788d274516)
1. [Argo CD — Resource Hooks (PreSync, PostSync, Sync, and SyncFail) and Sync Waves](https://medium.com/@raosharadhi11/argo-cd-resource-hooks-presync-postsync-sync-and-syncfail-and-sync-waves-e753c6f02d85)
1. [Argo Notifications with Argo CD](https://medium.com/@raosharadhi11/argo-notifications-with-argo-cd-d6ca0dc54cbc)
1. [ArgoCD with Vault using argocd-vault-plugin](https://medium.com/@raosharadhi11/argocd-with-vault-using-argocd-vault-plugin-dccbc302f0c2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. [ArgoCD with Vault using argocd-vault-plugin](https://medium.com/@raosharadhi11/argocd-with-vault-using-argocd-vault-plugin-dccbc302f0c2)
1. [ArgoCD with Vault using argocd-vault-plugin](https://medium.com/@raosharadhi11/argocd-with-vault-using-argocd-vault-plugin-dccbc302f0c2)

I'm still not sure if we would like to link these blogs in the readme unless it's published on argo blog medium.

nitishfy
nitishfy suggested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more reviews to address this PR. Also please fix the Lint Issues.

revitalbarletz
revitalbarletz reviewed Nov 4, 2024
View reviewed changes
README.md
@@ -86,4 +84,7 @@ Participation in the Argo CD project is governed by the [CNCF Code of Conduct](h
1. [Using Argo CD & Datree for Stable Kubernetes CI/CD Deployments](https://youtu.be/17894DTru2Y)
1. [How to create Argo CD Applications Automatically using ApplicationSet? "Automation of GitOps"](https://amralaayassen.medium.com/how-to-create-argocd-applications-automatically-using-applicationset-automation-of-the-gitops-59455eaf4f72)
1. [Progressive Delivery with Service Mesh – Argo Rollouts with Istio](https://www.cncf.io/blog/2022/12/16/progressive-delivery-with-service-mesh-argo-rollouts-with-istio/)

1. [Argo CD - A GitOps Tool for continuous Delivery](https://medium.com/@raosharadhi11/argo-cd-a-gitops-tool-for-continuous-delivery-12788d274516)
1. [Argo CD — Resource Hooks (PreSync, PostSync, Sync, and SyncFail) and Sync Waves](https://medium.com/@raosharadhi11/argo-cd-resource-hooks-presync-postsync-sync-and-syncfail-and-sync-waves-e753c6f02d85)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment - see how the dash is different in line #87 & #88 -
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revitalbarletz revitalbarletz revitalbarletz left review comments

@nitishfy nitishfy nitishfy requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharadhirao @revitalbarletz @nitishfy