Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkce): 20202 Backport PKCE auth flow fix for basehref and reauth #20675

Open
wants to merge 2 commits into
base: release-2.13
Choose a base branch
from
Open

fix(pkce): 20202 Backport PKCE auth flow fix for basehref and reauth #20675

wants to merge 2 commits into from

Commits on Nov 5, 2024

  1. fix(pkce): 20111 PKCE auth flow does not return user to previous path… 

    … like dex auth flow (argoproj#20202)

* Adding non-default basehref support for PKCE auth flow

Signed-off-by: austin5219 <[email protected]>

* Adding ; for linting

Signed-off-by: austin5219 <[email protected]>

* removing hook function

Signed-off-by: austin5219 <[email protected]>

* Moving unauthorized error handling to class component to access context for error handling within 401 error

Signed-off-by: austin5219 <[email protected]>

* Store the subsrition handle to close in unmount

Signed-off-by: austin5219 <[email protected]>

* reorder imports

Signed-off-by: austin5219 <[email protected]>

* Actually saving the subscriptions now

Signed-off-by: austin5219 <[email protected]>

* returning the 401 subscription from helper function

Signed-off-by: austin5219 <[email protected]>

* Handle the promise of a subscription

Signed-off-by: austin5219 <[email protected]>

* Removing then from non async subscribe

Signed-off-by: austin5219 <[email protected]>

* Linter fixes

Signed-off-by: austin5219 <[email protected]>

* Adding path caching to sessionStorage on pkceLogin and redirect step to cached path if available in pkceCallback to mirror Dex functionality

Signed-off-by: austin5219 <[email protected]>

---------

Signed-off-by: austin5219 <[email protected]>
    @austin5219
    austin5219 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    61e7ad1 View commit details
    Browse the repository at this point in the history

  2. Merge Conflict fix 

    Signed-off-by: austin5219 <[email protected]>
    @austin5219
    austin5219 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    47ab083 View commit details
    Browse the repository at this point in the history