fix: Make usage of quotes for templating consistent

[raweber42]

Checklist:

• [c] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

I got confused with the usage of single and double quotes. I don't think there is any significance in using double quotes around the .values templating value, is there? In line 237, single quotes are being used, too. So I guess this would be good for consistency. In general: I am wondering: When do we use single/double quotes? I didn't find any difference in how ArgoCD expands variables etc within single vs double quotes.

[bunnyshell]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[crenshaw-dev]

The user only needs to make sure that the field is a YAML string. Beyond that, Argo has no opinion on (or knowledge of) the string delimitation.

[raweber42]

@crenshaw-dev alright, thank you!

But then I think it would be wise to consistently use single or double quotes across the argocd documentation to reduce room for speculation (like for me).

If you approve of this, I am happy to create an extensive PR to update the usage examples across the ArgoCD docs.

[crenshaw-dev]

I don't feel strongly either way 🙂

[nitishfy]

Suggested change

	path: '{{.values.base_dir}}/apps/guestbook'
	path: '{{.values.base_dir}}/apps/guestbook'

I personally think it isn't necessary. If we change it to single dash, this gives the user a perspective that only single dash could be used (unless they try double dash too). Having both sort of examples makes sense. Although you're correct about consistency around docs but I don't think it's such a big change that needs to be consistent across all docs. Having said that, I'm proposing to revert the changes.