Skip to content

chore(deps): update github.com/antonmedv/expr v1.15.2 to github.com/expr-lang/expr v1.17.0 #22611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: release-2.12
Choose a base branch
from

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Apr 9, 2025

This change updates github.com/antonmedv/expr v1.15.2 to github.com/expr-lang/expr v1.17.0"

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@aali309 aali309 requested review from a team as code owners April 9, 2025 00:37
@aali309
Copy link
Contributor Author

aali309 commented Apr 9, 2025

I used this #19277 as guidance

@aali309 aali309 force-pushed the replaceantonmedvToexpr-lang branch from 059ab1f to 0120239 Compare April 11, 2025 19:33
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.59%. Comparing base (85be9a4) to head (4bd7961).
Report is 31 commits behind head on release-2.12.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.12   #22611      +/-   ##
================================================
+ Coverage         49.58%   49.59%   +0.01%     
================================================
  Files               313      313              
  Lines             52875    53062     +187     
================================================
+ Hits              26216    26317     +101     
- Misses            24179    24237      +58     
- Partials           2480     2508      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -117,6 +117,7 @@ require (
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.1.0 // indirect
github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v0.5.2 // indirect
github.com/antonmedv/expr v1.15.2 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected the old dep to still be present?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is expected that the old antonmedv/expr dependency is still present as an indirect dependency. This is because other packages in the project still depend on it. When we try to remove it completely, go mod tidy adds it back because it's required by other dependencies.

@aali309 aali309 force-pushed the replaceantonmedvToexpr-lang branch from 1b14888 to 4bd7961 Compare April 14, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants