-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore(deps): update github.com/antonmedv/expr v1.15.2 to github.com/expr-lang/expr v1.17.0 #22611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-2.12
Are you sure you want to change the base?
chore(deps): update github.com/antonmedv/expr v1.15.2 to github.com/expr-lang/expr v1.17.0 #22611
Conversation
I used this #19277 as guidance |
059ab1f
to
0120239
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.12 #22611 +/- ##
================================================
+ Coverage 49.58% 49.59% +0.01%
================================================
Files 313 313
Lines 52875 53062 +187
================================================
+ Hits 26216 26317 +101
- Misses 24179 24237 +58
- Partials 2480 2508 +28 ☔ View full report in Codecov by Sentry. |
@@ -117,6 +117,7 @@ require ( | |||
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.1.0 // indirect | |||
github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0 // indirect | |||
github.com/AzureAD/microsoft-authentication-library-for-go v0.5.2 // indirect | |||
github.com/antonmedv/expr v1.15.2 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected the old dep to still be present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is expected that the old antonmedv/expr
dependency is still present as an indirect dependency. This is because other packages in the project still depend on it. When we try to remove it completely, go mod tidy
adds it back because it's required by other dependencies.
…xpr-lang/expr v1.17.0 Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]> fix test failures Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
1b14888
to
4bd7961
Compare
This change updates github.com/antonmedv/expr v1.15.2 to github.com/expr-lang/expr v1.17.0"
Checklist: