Skip to content

fix(ApplicationSet): Check strategy type to verify it's a progressive sync (cherry-pick #22563) #22833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(ApplicationSet): Check strategy type to verify it's a progressive sync (#22563)

Signed-off-by: Fernando Crespo Gravalos [email protected]
Signed-off-by: Fernando Crespo Grávalos [email protected]
Co-authored-by: rumstead [email protected]

… sync (#22563)

Signed-off-by: Fernando Crespo Gravalos <[email protected]>
Signed-off-by: Fernando Crespo Grávalos <[email protected]>
Co-authored-by: rumstead <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner April 30, 2025 16:22
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.28%. Comparing base (b163de0) to head (3f85c2d).
Report is 1 commits behind head on release-2.14.

Files with missing lines Patch % Lines
...cationset/controllers/applicationset_controller.go 55.55% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-2.14   #22833   +/-   ##
=============================================
  Coverage         55.28%   55.28%           
=============================================
  Files               339      339           
  Lines             57345    57349    +4     
=============================================
+ Hits              31702    31706    +4     
- Misses            22949    22953    +4     
+ Partials           2694     2690    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rumstead rumstead merged commit f7ad2ad into release-2.14 Apr 30, 2025
23 of 25 checks passed
@rumstead rumstead deleted the cherry-pick-35f340-release-2.14 branch April 30, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants