fix: Fix Sensor Validation for admission webhook #3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko-be
force-pushed
the
fix-sensor-validation
branch
2 times, most recently
from
921d3e1 to
1dd1023
Compare
Signed-off-by: Ko Uchiyama <[email protected]>
ko-be
force-pushed
the
fix-sensor-validation
branch
from
1dd1023 to
f2771d1
Compare
christianh814
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been running into an issue when deleting sensors, when the eventbus has already been deleted. When we try to remove the finalizer from a sensor we're attempting to force delete, the admission webhook denies the request with:
This PR should fix this bug.
While creating additional test cases to catch this bug, also noticed that the current code panics when eventBusClient is nil, so added a guard against that as well.
Checklist: