-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add content-md5 header for artifacts #14140
base: main
Are you sure you want to change the base?
fix: add content-md5 header for artifacts #14140
Conversation
I checked out your branch locally and ran I'm not sure why it doesn't work for you, but if you aren't using the DevContainer, I suggest trying that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be verbose in the docs why we need to set sendContentMd5
to true
@akloss-cibo can you cherry-pick rohankmr414@c092458 on this branch to include the codegen changes, I've run |
ed4eaad
to
7376988
Compare
This change will allow objects to be written to buckets with S3 Object Lock enabled. fixes argoproj#11182 Signed-off-by: Alec Kloss <[email protected]>
Signed-off-by: Rohan K <[email protected]>
Signed-off-by: Alec Kloss <[email protected]>
7376988
to
f4d46e7
Compare
I don't think it is necessary for this to be configurable. Perhaps #14191 will be easier to get merged. |
This change will allow objects to be written to buckets with S3 Object Lock enabled.
I have manually fixed bits of the jsonschema and swagger, but I've been unable to build the Java client locally. It's not entirely clear to me that this PR needs to include those changes, but it seems like it does. If a kind soul can give me a tip on getting it to build, I'm happy to try again. (See this comment in the issue.)
Fixes #11182
Motivation
As described in 11182, being able to use an object-lock enabled S3 bucket is desirable for organizations wanted to protect assets from destruction.
Modifications
Added
sendContentMD5
setting to S3 artifact configuration, and use that setting to enable sending the MD5 via argoproj/pkg.Verification
I have built images using this code and enabled this setting and objects appear correctly in S3.
Here's the relevant part of the
workflow-controller-configmap
:Here's an example artifact: