all: support docker:// with dind
#215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
force-pushed
the
g/dind
branch
4 times, most recently
from
e430a49 to
f7b81d8
Compare
giautm
changed the title
docker:// with Dinddocker:// with dind
noamcattan
reviewed
Oct 16, 2024
| COPY --from=atlas /usr/local/bin/atlas /usr/local/bin | ||
| RUN chmod +x /usr/local/bin/atlas | ||
| ENV ATLAS_KUBERNETES_OPERATOR=1 | ||
| COPY --from=docker /usr/local/bin/docker /usr/local/bin |
There was a problem hiding this comment.
why not simply run apk add docker ?
There was a problem hiding this comment.
I want to version the docker cli, also need only one binary. Nothing else.
There was a problem hiding this comment.
btw, I'm not sure if we should bundle docker-cli with the default image, or create a separated tag for dind support
There was a problem hiding this comment.
The second option sounds reasonable
giautm
commented
Oct 16, 2024
| metadata: | ||
| name: atlasschema-postgres | ||
| spec: | ||
| devURL: docker://postgres/15/dev |
There was a problem hiding this comment.
This is impossible before this PR.
giautm
commented
Oct 16, 2024
Comment on lines
+40
to
+47
| image: docker:27.3.1-dind-rootless | ||
| securityContext: | ||
| privileged: true | ||
| runAsGroup: 1000 | ||
| runAsUser: 1000 | ||
| volumeMounts: | ||
| - name: dind-sock | ||
| mountPath: /run/user |
There was a problem hiding this comment.
Maybe replace dind with nerdctl to interactive directly with containerd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.