Skip to content

Conversation

ronenlu
Copy link
Member

@ronenlu ronenlu commented Sep 30, 2025

No description provided.

@ronenlu ronenlu changed the title atllasexec: add schema stats to SDK client atlasexec: add schema stats to SDK client Sep 30, 2025
@ronenlu ronenlu requested a review from giautm September 30, 2025 07:55
@ronenlu ronenlu assigned a8m and unassigned a8m Sep 30, 2025
@ronenlu ronenlu requested review from a8m and datdao September 30, 2025 07:56
@ronenlu ronenlu requested a review from datdao September 30, 2025 08:58
@ronenlu ronenlu requested a review from datdao September 30, 2025 09:49
@ronenlu ronenlu changed the title atlasexec: add schema stats to SDK client atlasexec: add schema stats inspect to SDK client Sep 30, 2025
Copy link
Member

@datdao datdao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariga ariga deleted a comment from datdao Sep 30, 2025
return nil, fmt.Errorf("failed to parse prometheus metrics: %w", err)
}
for _, mf := range metricFamilies {
if mf.GetName() == "atlas_table_size_bytes" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, feels less safe.

@giautm WDYT?

@ariga ariga deleted a comment from datdao Sep 30, 2025
@ariga ariga deleted a comment from ronenlu Sep 30, 2025
@ariga ariga deleted a comment from datdao Sep 30, 2025
@ariga ariga deleted a comment from datdao Sep 30, 2025
@ronenlu ronenlu merged commit 649bc35 into master Sep 30, 2025
28 checks passed
@ronenlu ronenlu deleted the schema_stats branch September 30, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants