Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompt: show desc for each prompt #331

Merged
merged 2 commits into from
Aug 30, 2024
Merged

prompt: show desc for each prompt #331

merged 2 commits into from
Aug 30, 2024

Conversation

luantranminh
Copy link
Contributor

@luantranminh luantranminh commented Aug 30, 2024 •
edited
Loading

Before After
image image

What’s changing?

There is no change to the output file, only in how we present information to users through the interactive prompt, including:

  • Each prompt will have its own description after confirmation.
  • Instead of opening the browser directly, ask for confirmation beforehand

@luantranminh luantranminh force-pushed the l/enhance branch 2 times, most recently from 5484d57 to 7b4f629 Compare August 30, 2024 13:10
ronenlu
ronenlu previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@ronenlu ronenlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@luantranminh luantranminh merged commit e00e92e into master Aug 30, 2024
3 checks passed
@luantranminh luantranminh deleted the l/enhance branch August 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giautm giautm giautm approved these changes

@ronenlu ronenlu ronenlu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luantranminh @giautm @ronenlu