Dismiss search on touch suggestions list margins #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardbosch
force-pushed
the
feature/disable_scroll_within_suggestions_margins
branch
from
9ab2204 to
4f72f61
Compare
Author
|
Added maven library to use jitpack |
Author
|
Updated some missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi to all 🎉
I've fixed an issue where touch is propagated below floating search views when it's focused.
The bug
I've checked the issue in the sample app by removing the 5dp margins to the
search_results_listinfragment_sliding_search_results_example_fragment.xml. Then you can see that this bug appears:The fix
To avoid this, I've changed the touch listener to dismiss the search from
mSuggestionsSectionto theFloatingSearchViewitself, because it occupies the whole screen.Now it works well