Feat(eos_cli_config_gen): Add support for BGP default timers and send-community commands

[Shivani-gslab]

Change Summary

Add support for BGP default timers and send-community commands

Related Issue(s)

Fixes #4218

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

router_bgp:
      timers:

        # Time between BGP keepalive messages in seconds.
        # `keepalive_time` should be lesser than `hold_time`.
        keepalive_time: <int; 0-3600>

        # Hold time in seconds. Must be defined along with `keepalive_time`.
        # The valid values are 3-7200 or 0 if both values are 0.
        hold_time: <int; 0-7200>

        # Neighbor's minimum hold time constraint in seconds.
        # `min_hold_time` should be less than `hold_time`.
        min_hold_time: <int; 3-7200>

        # Send failure hold time in seconds.
        send_failure_hold_time: <int; 60-65535>
      neighbor_default:
        send_community: <str; "all" | "large" | "extended" | "standard" | "extended large" | "standard large" | "standard extended" | "standard extended large">

How to test

Match with EOS CLI.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4607
# Activate the virtual environment
source test-avd-pr-4607/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@bgp_timers_send_community#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,bgp_timers_send_community --force
# Optional: Install AVD examples
cd test-avd-pr-4607
ansible-playbook arista.avd.install_examples

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[ClausHolbechArista]

I my test the timers comes after the no bgp default ipv4-unicast

[alexeygorbunov]

+1

+router bgp 65101
+   router-id 192.168.255.3
+   no bgp default ipv4-unicast
+   timers bgp min-hold-time 5 send-failure hold-time 65
+   distance bgp 20 200 200
+   graceful-restart restart-time 300
+   graceful-restart
+   maximum-paths 2 ecmp 2
+   neighbor default send-community standard extended large
+   neighbor EVPN-OVERLAY-PEERS peer group
+   neighbor EVPN-OVERLAY-PEERS remote-as 65001
+   neighbor EVPN-OVERLAY-PEERS update-source Loopback0

[Shivani-gslab]

Yes, the ordering is same in the template, this mismatch in the ordering of this file is because these commands are defined under bgp_defaults key, which is below timers in the template.

We can see the correct ordering in router-bgp-base.cfg

[Shivani-gslab]

https://github.com/aristanetworks/avd/blob/devel/ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-evpn-mpls.yml#L4

[alexeygorbunov]

LGTM