Adds support for List and Map DynVal.
#197
Open
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In aristidb/pull/177, @puffnfresh added support for - Null - Lists (L) - Map (M) where Lists are represented as `DList (Vector DValue)` and Maps as `DMap (Map Text Dvalue)`. This adds `DynVal` instances for `Vector` and `Map Text` to allow them to be used when parsing a structure into records.
Contributor
Author
|
This replaces /pull/192, fixing up the commit messages. |
Owner
|
Can you please add short comments to the code explaining the difference between the [], Set, Vector and Map instances? Because I do find that somewhat confusing. (Of course, partially the confusingness stems from the fact that Amazon first tried to use a simplistic data model and then added more complex features, while leaving the simplistic form distinct and present.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In /pull/177, @puffnfresh added support for
where Lists are represented as
DList (Vector DValue)andMaps as
DMap (Map Text Dvalue).This adds
DynValinstances forVectorandMap Texttoallow them to be used when parsing a structure into records.