Skip to content

Conversation

@Starlitnightly
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR translates all Chinese docstrings and inline comments in the MERFISHVI module to English, renames the base class from SpatialSCVI to SpatialVI, and updates the package exports accordingly.

  • Translated docstrings and comments from Chinese to English throughout _module.py
  • Renamed SpatialSCVI to SpatialVI in _model.py (class name, summary string, and setup docs)
  • Updated __init__.py to export SpatialVI instead of SpatialSCVI

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
spateo/external/MERFISHVI/_module.py Converted Chinese docstrings/comments to English for inference, generative, and loss functions
spateo/external/MERFISHVI/_model.py Renamed SpatialSCVI to SpatialVI, updated model-summary and setup docs
spateo/external/MERFISHVI/init.py Replaced export of SpatialSCVI with SpatialVI
Comments suppressed due to low confidence (4)

spateo/external/MERFISHVI/_model.py:471

  • Update this docstring to reflect the new base class: change 'extends SCVI' to 'extends SpatialVI'.
This model extends SCVI to simultaneously process MERFISH data with spatial information and

spateo/external/MERFISHVI/_model.py:46

  • Consider adding a deprecated alias SpatialSCVI = SpatialVI or a clear migration note to avoid breaking users who still reference SpatialSCVI.
class SpatialVI(

spateo/external/MERFISHVI/init.py:1

  • If backward compatibility is required, consider temporarily re-exporting SpatialSCVI as an alias with a deprecation warning.
from ._model import MERFISHVI, SpatialVI

@Starlitnightly Starlitnightly merged commit f2c088a into aristoteleo:main Jun 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant