Fix issues in codegen and traversal #1464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1460 and #1453
The codegen logic had an issue where it would generate the function for the pipe, but never actually call it.
This changes the codegen logic to create the call, though you should definitely look over this part since I am not too familiar with it
It also ensures proper cleanup before returning in the traversal logic since previously it may leave stale state leading to internal throws.
I added 3 tests that failed previously and now pass