perf: optimize Projective + Bucket addition with explicit formula #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PivasDesant
requested review from
Pratyush,
mmagician and
z-tech
and removed request for
a team
Member
|
Thanks for the PR! The CI seems to be failing. It would also be nice to have a reference to how the formula was derived. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the TODO that was converting Bucket to Projective before adding.
Now we compute the addition directly using Bucket's zz/zzz coordinates, which should be faster since we skip the conversion step.
Also fixed a bug in the U2 calculation - was missing the z2z2 multiplication.