Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): added serialize_extra and deserialize_extra feature flags #596

Closed
wants to merge 1 commit into from

Conversation

lasantosr
Copy link

@lasantosr lasantosr commented Aug 25, 2024

Summary

This pull request closes #594 by adding two additional feature flags: serialize_extra and deserialize_extra

These feature flags are meant to be manually enabled by downstream crates on any individual crate they might require, leaving the default serialize/deserialize features unaltered.

Checklist

@lasantosr lasantosr changed the title feat: added serialize_extra and deserialize_extra feature flags feat(next): added serialize_extra and deserialize_extra feature flags Aug 26, 2024
@mzeitlin11
Copy link
Collaborator

This generally looks good, thanks! Probably want to wait for #597 to remove borrowed cases (since some of the extra deserialize derives are on request types which borrow data, tricky to use).

Once #597 is in, I'm hoping the feature story could be even simpler since then request parameters and return types could be treated the same with respect to generation of derives, simplifying everything a ton. Right now there's serialize, deserialize, serialize-extra, and deserialize-extra - hopefully then that could be collapsed into just one serialize and deserialize flag each to enable always deriving those traits.

@lasantosr
Copy link
Author

It was my bad, I didn't see the manual implementation of serialize for the types.

I'm closing this PR as it doesn't make much sense, sorry!

@lasantosr lasantosr closed this Sep 7, 2024
@arlyon
Copy link
Owner

arlyon commented Sep 24, 2024

No worries @lasantosr thanks for taking the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants