Scala Client: add new jobWatcher() method for watcher API #4606
+212
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new jobWatcher(queue, jobset, lastMessage) method to ArmadaClient class,
based on original logic in armada-spark repository.
Fill in implementation of watch() method in ArmadaClientSuite (test)
EventMockServer. Clear out job, queue, and status maps (the backing store for
the ArmadaMockServer) before running each test, to avoid test pollution.
Change from using .onComplete{..} idiom to Await.result(response, timeout) for
more robust async testing behavior. Add test for jobWatcher(), verify that
expected events do arrive and in expected order.
Fixes G-Research/spark#160
Signed-off-by: Rich Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new jobWatcher(queue, jobset, lastMessage) method to ArmadaClient class, based on original logic in armada-spark repository.
Fill in implementation of watch() method in ArmadaClientSuite (test) EventMockServer. Clear out job, queue, and status maps (the backing store for the ArmadaMockServer) before running each test, to avoid test pollution.
Change from using .onComplete{..} idiom to Await.result(response, timeout) for more robust async testing behavior. Add
watchsupport to testing mock server, add unit test for jobWatcher().Fixes G-Research/spark#160