Improve editor configuration and add --config file #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
armandsauzay
commented
Dec 16, 2024
armandsauzay
commented
- Add ConfigDir to Config struct to properly track config location
- Rename DefaultEditor to Editor for consistency
- Add GetEditor() with proper fallback chain:
- Config file setting
- NOTE_EDITOR env var
- VISUAL env var
- EDITOR env var
- /usr/bin/vi
- /bin/ed as final fallback
- Add --config flag to print config location and contents
- Fix config file location to use ConfigDir instead of NotesDir
- Improve directory creation handling
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.