Skip to content

Update PR filtering logic in release logs workflow #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update PR filtering logic in release logs workflow #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/generate-release-logs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,20 @@ jobs:
title=$(jq -r .title <<<"$pr")
author=$(jq -r .user.login <<<"$pr")
pr_url=$(jq -r .html_url <<<"$pr")

# Skip bots and worker accounts
if [[ "$author" == "github-actions[bot]" || "$author" == "dependabot[bot]" || "$author" == "armbianworker" || "$author" == "armbianworker[bot]" ]]; then
continue

# Skip bots, workers, and bump/revert PRs
title_lc="$(echo "$title" | tr '[:upper:]' '[:lower:]')"
if [[ "$author" == "github-actions[bot]" || \
"$author" == "dependabot[bot]" || \
"$author" == "armbianworker" || \
"$author" == "armbianworker[bot]" || \
"$title_lc" == bump* || \
"$title_lc" == revert* || \
"$title_lc" =~ "bump "* || \
"$title_lc" =~ "revert "* ]]; then
Comment on lines +128 to +136
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix the bump/revert matcher.

The new =~ "bump "* / =~ "revert "* checks never fire for titles like “feat: bump deps” because the regex becomes bump *, which only matches bump followed by spaces. As a result, the workflow still includes the very PRs we meant to skip. Please tighten the condition, e.g.:

-            if [[ "$author" == "github-actions[bot]" || \
-                  "$author" == "dependabot[bot]" || \
-                  "$author" == "armbianworker" || \
-                  "$author" == "armbianworker[bot]" || \
-                  "$title_lc" == bump* || \
-                  "$title_lc" == revert* || \
-                  "$title_lc" =~ "bump "* || \
-                  "$title_lc" =~ "revert "* ]]; then
+            if [[ "$author" == "github-actions[bot]" || \
+                  "$author" == "dependabot[bot]" || \
+                  "$author" == "armbianworker" || \
+                  "$author" == "armbianworker[bot]" ]]; then
+                  continue
+            fi
+
+            if [[ "$title_lc" =~ ^(bump|revert)\b || \
+                  "$title_lc" =~ (^|[^[:alnum:]])(bump|revert)\b ]]; then
                   continue
             fi

That reliably kills PRs whose titles start with—or contain a scoped prefix plus—“bump”/“revert”.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
.github/workflows/generate-release-logs.yml around lines 128-136: the =~ "bump
"* and =~ "revert "* tests produce incorrect regexes and miss titles like "feat:
bump deps"; replace those two conditions with regexes that match word boundaries
or non-alphanumeric separators (for example =~ '(^|[^[:alnum:]])bump' and =~
'(^|[^[:alnum:]])revert') so titles that start with or contain scoped prefixes
plus "bump"/"revert" are correctly detected and skipped.

continue
fi

# Output tab-separated: title, author, repo, pr_number, pr_url
printf "%s\t%s\t%s\t%s\t%s\n" "$title" "$author" "$repo" "$num" "$pr_url"
done | LC_ALL=C sort -f -t $'\t' -k1,1 > "$outfile"
Expand Down