Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #6644

Merged
merged 2 commits into from
May 21, 2024
Merged

Minor fixes #6644

merged 2 commits into from
May 21, 2024

Conversation

viraniac
Copy link
Collaborator

Description

Minor fixes:

  • limit creation of git-sources.json file to following commands - targets, debs-to-repo-json, gha-matrix and gha-workflow
  • Solve slowness when building Ubuntu Noble images. Fixes Building ubuntu 24.04 image is slow #6531

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Tested Ubuntu noble rootfs creation speed improvement using ./compile.sh BOARD=khadas-vim4 BRANCH=legacy KERNEL_CONFIGURE=no BUILD_MINIMAL=yes RELEASE=noble ARTIFACT_IGNORE_CACHE=yes rootfs. It reduced build time from 26 minutes down to only 8 minutes.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@viraniac viraniac requested review from a team and igorpecovnik as code owners May 20, 2024 13:17
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... labels May 20, 2024
@viraniac viraniac added the Needs review Seeking for review label May 21, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release labels May 21, 2024
@igorpecovnik igorpecovnik merged commit b2cc35d into armbian:main May 21, 2024
4 checks passed
@Tiryoh Tiryoh mentioned this pull request Jun 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building ubuntu 24.04 image is slow
2 participants
@viraniac @igorpecovnik