rk322x: fixes uboot v2024.01 interoperability with vendor kernel #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multitool utility uses the legacy/vendor 4.4 kernel and it was failing to turn on HDMI properly. Assert and deassert all vop and hmdi resets to clean up the state on uboot exit seems to solve the issue
uboot default behaviour is the assert resets when it has to pass control to the kernel. This may cause compatibility issues if the kernel driver is not instructed to properly deassert the resets, so we change the uboot behaviour for dwc and ehci usb drivers to deassert reset on exit.
github-actions
bot
added
size/medium
chainsx
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uboot v2024.01 leaves HDMI/VOP and USB ports in a state that is not liked by vendor kernel and tools that use it (eg. the multitool), thus making their usage difficult or impossible.
These patches will assert the resets for HDMI, VOP and USB ports and deassert them on uboot exit, so the kernel (any kernel) will find them in active and "clean" state.
Nerd note: the USB nodes in uboot device tree do not have the
resetproperties. Adding theresetproperties makes the USB ports undetectable to the kernel because uboot - on purpose - leaves the devices with the reset asserted. To let the kernel detect the ports, you have to add theresetproperties in the kernel device tree too, so the kernel is able to deassert them. A more complete device tree is not always to be a good thing, for uboot at least.Jira reference number AR-2349
How Has This Been Tested?
Checklist: