-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the unthinkable: rockchip-rk3588 current
(to 6.8.12, EOL and non-LTS!) and edge
to 6.10-rc2 (from #6699)
#6717
Conversation
Important: this does not enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments below.
Overall, I'd still wait a while and see what others think. If 6.10 can be fixed soon, we don't need to break the convention that current
has to be an LTS kernel.
a8ab19b
to
76ffdd2
Compare
Updated based on recent changes in #6699 (incl -rc3 bump + patch rewrite, and @amazingfate 's dts-to-patches for sige7 + path change + patch rewrite). |
76ffdd2
to
33460a9
Compare
I also have thoughts, but on the other hand - let the users play with it? 6.10 won't be stable / LTS fixed very soon and this could be the thing for awhile? |
- Bump mainline kernel from 6.10-rc1 to 6.10-rc2 - Remove patches which are now mainlined - Re-number "fix-initial-PERST-GPIO-value" patch as per number ordering seen in 0000.patching_config.yaml - Rewrite kernel config
"general-add-overlay-compilation-support.patch" became obsolete in Linux 6.9 (see AR-2352 [1]). Fix this problem: - Rename *.dts sources in overlay directory to *.dtso - Change "target +=" line to "dts-y +=" in overlay Makefile - Remove "always +=" line in overlay Makefile - Add .scr compilation support in kernel scripts/Makefile.lib - Patch kernel scripts/Makefile.dtbinst to avoid flattening overlay directory For the last two points, see general-add-overlay-compilation-support.patch Credits for this fix go to @paolosabatino [1] https://armbian.atlassian.net/browse/AR-2352
This simplifies the process updating to newer kernel versions and makes it easier to see and edit the actual dts file being used.
Patches are from the Linux Rockchip Mailing List, submitted by Alexey Charkov. [1] Notable improvements from changelog: - Moved the TSADC enablement to per-board .dts/.dtsi files - Dropped extra "inefficient" OPPs (same voltage - lower frequencies) - Dropped second passive cooling trips altogether to keep things simple - Added a cooling map for passive GPU cooling (in a separate patch) - Added regulator coupling for EVB1 and QuartzPro64 Also enable automatic fan control on Rock 5B. [1] https://lore.kernel.org/linux-rockchip/[email protected]/
The old driver didn't build on 6.10, so the kernel build couldn't finish. Link to the added patch series: https://lore.kernel.org/all/20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com/
…copied) - lets move to standard patch dir for this family - patches are being copied (not moved) on purpose; we've already PR open to move to 6.10-rcX
…anges) - CONFIG_EXPERT is now yes in armbian code, it reflects here
…fconfig against v6.8.12 (EOL)
…ve/rockchip-rk3588-6.10` - no changes
…efault convention now (under `archive/rockchip-rk3588-x.z`)
…in kernel config filenames - `LINUXCONFIG="linux-rockchip-rk3588-${KERNEL_MAJOR_MINOR}" # Attention: not -${BRANCH} (edge/current/legacy), -but ${KERNEL_MAJOR_MINOR} thus 6.8 / 6.10 etc`
…d path + rewritten patches) - rpardini was here and adapted this to archive/ path and rewrote patches using newly-merged patching tool with stable index stanzas
- interesting that with stable index stanzas, we get to clearly see patches that actually changed only in position during rewrites
33460a9
to
16b0fb6
Compare
Fast review on 3 targets :
Will try to connect serial port when I have some time Anyway, thank's for working on this ;-) |
Thanks for testing! HDMI has unresolved issues which make the board not even boot when the HDMI nodes in the devicetree are active, see also #6699 (comment) Also nice to see that more people than me got the CM3588 NAS now 🔥 |
This effort kindly adopted by @ColorfulRhino into #6699 - closing! |
the unthinkable: rockchip-rk3588
current
(to 6.8.12, EOL and non-LTS!) andedge
to 6.10-rc2 (from #6699)ordering seen in 0000.patching_config.yaml
"general-add-overlay-compilation-support.patch" became obsolete in
Linux 6.9 (see AR-2352 [1]). Fix this problem:
directory
For the last two points, see
general-add-overlay-compilation-support.patch
Credits for this fix go to @paolosabatino
[1] https://armbian.atlassian.net/browse/AR-2352
This simplifies the process updating to newer kernel versions and makes
it easier to see and edit the actual dts file being used.
Patches are from the Linux Rockchip Mailing List, submitted by Alexey
Charkov. [1]
Notable improvements from changelog:
Also enable automatic fan control on Rock 5B.
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
The old driver didn't build on 6.10, so the kernel build couldn't finish.
Link to the added patch series:
https://lore.kernel.org/all/20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com/
oldedge
pointing to 6.8oldedge
pointing to 6.8; preserve .configoldedge
pointing to 6.8; update .config (no changes)oldedge
pointing to 6.8; convert .config to defconfig against v6.8.12 (EOL)rockchip-rk3588-edge
(6.10) patches toarchive/rockchip-rk3588-6.10
archive/rockchip-rk3588-x.z
)current
(6.8) andedge
(6.10) - use major+minor in kernel config filenamesLINUXCONFIG="linux-rockchip-rk3588-${KERNEL_MAJOR_MINOR}" # Attention: not -${BRANCH} (edge/current/legacy), -but ${KERNEL_MAJOR_MINOR} thus 6.8 / 6.10 etc