Odroid M1: add a network rule to rename default name

[igorpecovnik]

Description

Renaming network device to eth0

How Has This Been Tested?

• Generated image

Checklist:

• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[ColorfulRhino]

What's the difference between "${destination}" and "${SDCARD}" here?

[igorpecovnik]

What's the difference between "${destination}" and "${SDCARD}" here?

destination -> BSP package
SDCARD -> image only

[ColorfulRhino]

destination -> BSP package

Thanks! Which package is it in this case? Is this something a user could download/update to their existing image?

Do you think "${destination}" is better for this stuff in general? If so, we could change it on every board config, many use "${SDCARD}".

[igorpecovnik]

Which package is it in this case?

armbian-bsp-cli-$BOARD-$BRANCH

Is this something a user could download/update to their existing image?

yes, that's the idea.

[ColorfulRhino]

I thought about this a bit. Is it a good idea to change the name of a network interface via update package? Imagine if someone had for example set up some rules (static IP, ...) for this interface. Renaming via update might break those rules unless the old name remains as an alternate name and whatever network managing software they use recognizes this as the same interface.

So, maybe adding the new interface name "only" for new images wouldn't be that bad? I'm not sure, this is just what came to my mind, I haven't run any test.

[igorpecovnik]

So, maybe adding the new interface name "only" for new images wouldn't be that bad?

Yes, that you are right. Lets keep this for new images.

[ColorfulRhino]

Alright 👍
I don't have this board so I can't test that the interface is properly renamed. But from the code it looks okay.

[igorpecovnik]

I can't test

Tested.