fix: partitioning: disable orphan_file (FEATURE_C12) for ext4 filesystems on 1.47+ e2fsprogs host

[rpardini]

fix: partitioning: disable orphan_file (FEATURE_C12) for ext4 filesystems on 1.47+ e2fsprogs host

• fix: partitioning: disable orphan_file (FEATURE_C12) for ext4 filesystems on 1.47+ e2fsprogs host
  • otherwise:

    fsck.ext4 -a -C0 /dev/mmcblk0p1
    /dev/mmcblk0p1 has unsupported feature(s): FEATURE_C12
    e2fsck: Get a newer version of e2fsck!
    

  • orphan_file can only be disabled on recent-enough e2fsprogs, thus check version and compare

[rpardini]

To clarify: this fixes a problem that only happens if you use for example trixie to build a jammy image -- when the host supports (and defaults to enabling) orphan_file, but the target doesn't know about it.

[ColorfulRhino]

Do you know if this also happens when building a bookworm image or is it only jammy?

Maybe we should put some sort of hint/Todo in the code to clarify that this was only a temporary workaround until jammy image is not supported anymore. Otherwise someone will stumble over the code in 5 years and wonder why it's there and hasn't been removed.

[rpardini]

Do you know if this also happens when building a bookworm image or is it only jammy?

It's not only Jammy. Any distro with e2fsprogs > 1.47 as build host, and any distro with e2fsprogs < 1.47 as target will have this problem. (There is also a kernel interaction, as orphan_file needs support in the kernel too; but I think it's >5.15)

[rpardini]

someone will stumble over the code in 5 years and wonder why it's there and hasn't been removed.

git blame is that person's friend, and it will point to this PR ;-)