Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunxi64: temporally disable broken PWM_SUNXI_ENHANCE driver #7059

Closed
wants to merge 1 commit into from
Closed

sunxi64: temporally disable broken PWM_SUNXI_ENHANCE driver #7059

wants to merge 1 commit into from

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Aug 11, 2024 •
edited
Loading

Description

Need to be fixed after release. Some background in comments #6656

How Has This Been Tested?

  • CI build

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik
sunxi64: temporally disable broken PWM_SUNXI_ENHANCE driver
6340b28 
Need to be fixed after release. Some background in comments #6656
@igorpecovnik igorpecovnik added Build Executing build train (permission needed) 08 Milestone: Third quarter release labels Aug 11, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... labels Aug 11, 2024
@igorpecovnik igorpecovnik added Needs review Seeking for review and removed Build Executing build train (permission needed) labels Aug 11, 2024
@JohnTheCoolingFan JohnTheCoolingFan mentioned this pull request Aug 11, 2024
Merged
8 tasks
@igorpecovnik
Copy link
Member Author

Merged in #6656

@chraac
Copy link
Collaborator

chraac commented Aug 13, 2024

Sorry for reopening the dialog here, do we still need this PWM_SUNXI_ENHANCE driver in edge kernel?
Have seen through the compining error, and looks the driver use some old interface to calculate the pwm index, thus may need some extra work to adapt to new kernel pwm interface.

@igorpecovnik igorpecovnik deleted the temp-disable-pwm branch November 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGM1968 AGM1968 Awaiting requested review from AGM1968 AGM1968 is a code owner

@PanderMusubi PanderMusubi Awaiting requested review from PanderMusubi PanderMusubi is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte krachlatte is a code owner

@pyavitz pyavitz Awaiting requested review from pyavitz pyavitz is a code owner

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner

@teknoid teknoid Awaiting requested review from teknoid teknoid is a code owner

@viraniac viraniac Awaiting requested review from viraniac

Assignees
No one assigned
Labels
08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @chraac