Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userspace Switching armbian-config to new generation. #7189

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 8, 2024

Description

We had a long sage with complete rework of main hardware & system config tool. armbian-config still works, but it is largely unmaintained and bulky since early days. We tried several ways and failed ... New tool contains all what we learned by failing.

Closing #7428

https://docs.armbian.com/User-Guide_Armbian-Software/

Most functions were ported from old config which is the reason we are merging this soon.

How Has This Been Tested?

  • we have unit testing in place, but test cases were not developed / enabled for all functions yet
  • tested by developers and there might be bugs ... which should be reported at https://github.com/armbian/configng/issues
  • making a minimal CLI image, tool is present and functional out of the box

Checklist:

  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress Help needed We need your involvement Breaking change Can potentially break core functionality 11 Milestone: Fourth quarter release Giveaway labels Sep 8, 2024
@igorpecovnik igorpecovnik requested a review from a team as a code owner September 8, 2024 17:53
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Sep 8, 2024
@igorpecovnik igorpecovnik added Needs review Seeking for review and removed Work in progress Unfinished / work in progress labels Oct 7, 2024
@github-actions github-actions bot removed the Giveaway label Oct 18, 2024
@igorpecovnik igorpecovnik removed the Breaking change Can potentially break core functionality label Oct 25, 2024
@igorpecovnik igorpecovnik removed the Help needed We need your involvement label Oct 25, 2024
@igorpecovnik igorpecovnik force-pushed the armbian-config branch 2 times, most recently from 63b5575 to 2bc0069 Compare November 3, 2024 09:16
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Nov 3, 2024
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Nov 3, 2024
@github-actions github-actions bot removed the Ready to merge Reviewed, tested and ready for merge label Nov 3, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Nov 3, 2024
@igorpecovnik igorpecovnik added Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Nov 3, 2024
@schmiedelm
Copy link
Member

I have tried to build this commit and get the error message

/armbian/lib/functions/compilation/packages/armbian-config-deb.sh: line 71: sudo: command not found
[🐳|💥] Error 127 occurred in main shell [ at /armbian/lib/functions/compilation/packages/armbian-config-deb.sh:71
         compile_armbian-config() --> lib/functions/compilation/packages/armbian-config-deb.sh:71
                do_with_logging() --> lib/functions/logging/section-logging.sh:81
   artifact_armbian-config_build_from_sources() --> lib/functions/artifacts/artifact-armbian-config.sh:64
    artifact_build_from_sources() --> lib/functions/artifacts/artifacts-obtain.sh:34
       obtain_complete_artifact() --> lib/functions/artifacts/artifacts-obtain.sh:280
       build_artifact_for_image() --> lib/functions/artifacts/artifacts-obtain.sh:392
    main_default_build_packages() --> lib/functions/main/build-packages.sh:106
   full_build_packages_rootfs_and_image() --> lib/functions/main/default-build.sh:31
          do_with_default_build() --> lib/functions/main/default-build.sh:42
         cli_standard_build_run() --> lib/functions/cli/cli-build.sh:25
        armbian_cli_run_command() --> lib/functions/cli/utils-cli.sh:136
                 cli_entrypoint() --> lib/functions/cli/entrypoint.sh:176
                           main() --> compile.sh:50
 ]
[🐳|💥] Cleaning up [ please wait for cleanups to finish ]

…ll footprint, thus it will be installed by default
@igorpecovnik
Copy link
Member Author

Fixed, thanks!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Nov 5, 2024
@igorpecovnik igorpecovnik merged commit 48228f1 into main Nov 5, 2024
10 checks passed
@igorpecovnik igorpecovnik deleted the armbian-config branch November 5, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

3 participants