Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip-rk3588: use rkvdec2 patch from rockchip64 #7429

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

amazingfate
Copy link
Contributor

Description

The rkvdec2 patch rockchip-rk3588 uses now is from old version, and from chromium h264 is only up to 1920x1088.
After updating to the version from rockchip64 now it is 16x16 to 65520x6520 now.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • ./compile.sh kernel BOARD=armsom-sige7 BRANCH=edge KERNEL_CONFIGURE=no KERNEL_GIT=shallow

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Nov 2, 2024
@amazingfate amazingfate marked this pull request as draft November 2, 2024 16:33
@amazingfate
Copy link
Contributor Author

I find that the v3 patch will cause chromium decoding failed. Maybe it's better to stay at the v1 patch.

@amazingfate amazingfate marked this pull request as ready for review November 4, 2024 07:49
@amazingfate
Copy link
Contributor Author

According to discussions in v3 patch mailing list, reg and reg-names should match what the TRM describes.
And after changing the reg, now rk3588 can decode 4k h264 video in chromium. Although in 6.10 the origin v3 patch works, I don't know what it doesn't work in 6.11.
Also change the devicetree node of rk356x.
Test with ./compile.sh kernel BOARD=armsom-sige7 BRANCH=edge DEB_COMPRESS=xz KERNEL_CONFIGURE=no KERNEL_GIT=shallow for rock-5b
and ./compile.sh kernel BOARD=orangepi3b BRANCH=edge DEB_COMPRESS=xz KERNEL_CONFIGURE=no KERNEL_GIT=shallow for orangepi3b.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release labels Nov 4, 2024
@igorpecovnik igorpecovnik merged commit 345cf34 into armbian:main Nov 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants