Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pd negotiation support for bananapim7 #7483

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

amazingfate
Copy link
Contributor

Description

Bananapi M7 and ArmSoM Sige7 are just the same board, but the uboot pd negotiation patch of bpim7 is missiong. After this commit, there will be no boot loop when using pd power.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • ./compile.sh BOARD=bananapim7 BRANCH=vendor BUILD_MINIMAL=no DEB_COMPRESS=xz KERNEL_CONFIGURE=no RELEASE=noble KERNEL_GIT=shallow BUILD_DESKTOP=no ENABLE_EXTENSIONS=mesa-vpu

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Nov 16, 2024
@amazingfate amazingfate changed the title enable pd negotion support for bananapim7 enable pd negotiation support for bananapim7 Nov 16, 2024
@HeyMeco
Copy link
Contributor

HeyMeco commented Nov 16, 2024

Wouldn’t it make more sense to combine them to one config for the future?

@amazingfate
Copy link
Contributor Author

Wouldn’t it make more sense to combine them to one config for the future?

Bananapi has requested support for this board but this board is designed and produced by ArmSoM. And the mainline devicetree is armsom-sige7. We have to keep bananapim7 at the moment.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release and removed Needs review Seeking for review labels Nov 17, 2024
@igorpecovnik igorpecovnik merged commit a46a7cf into armbian:main Nov 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

4 participants